-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 Support #307
Merged
Merged
PHP 8.0 Support #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=========================================
Coverage 99.68% 99.68%
Complexity 351 351
=========================================
Files 20 20
Lines 940 940
=========================================
Hits 937 937
Misses 3 3 Continue to review full report at Codecov.
|
ankitpokhrel
force-pushed
the
php8
branch
4 times, most recently
from
November 1, 2020 18:12
18b9039
to
2cbd75b
Compare
ankitpokhrel
force-pushed
the
php8
branch
3 times, most recently
from
November 8, 2020 12:16
134949b
to
55faab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
guzzlehttp/guzzle
(Support added in v7.2.0. No changes needed.)nesbot/carbon
(Support added in >= v2.13.0. No changes needed.)predis/predis
(No changes needed for now. v2.0.0 will have full PHP8 support.)ramsey/uuid
(Support added in v3.9.2. No changes needed.)symfony/*
(Symfony packages already supports PHP 8.0)Dev Dependencies
friendsofphp/php-cs-fixer
(Remove from dev dependency PHP 8.0 support PHP-CS-Fixer/PHP-CS-Fixer#4702)mockery/mockery
(Support added in v1.4.1. Requires PHP >= 7.3. Also see Full PHP 8.0 Support mockery/mockery#1083.)phpunit/phpunit
(Upgrade to PHPUnit >= 9.3. This requires PHP >= 7.3)php-mock/php-mock
(Remove php-mock dependency - test: Remove php-mock dependency #308)Other Tasks
Drop PHP 7.2 support (?).: Nopredis/predis
dependency can be gracefully removed or deprecated (related Redis cluster mode #287). This will be done in the next major release.Note
nightly
and it is allowed to fail. Once the Travis target for PHP8 is added, we can update our step.