Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 Support #307

Merged
merged 14 commits into from
Nov 14, 2020
Merged

PHP 8.0 Support #307

merged 14 commits into from
Nov 14, 2020

Conversation

ankitpokhrel
Copy link
Owner

@ankitpokhrel ankitpokhrel commented Oct 31, 2020

Q A
Status Final
Type Improvement
BC Break None
Release Date N/A
Release Version 2.1.0

Dependencies

  • guzzlehttp/guzzle (Support added in v7.2.0. No changes needed.)
  • nesbot/carbon (Support added in >= v2.13.0. No changes needed.)
  • predis/predis (No changes needed for now. v2.0.0 will have full PHP8 support.)
  • ramsey/uuid (Support added in v3.9.2. No changes needed.)
  • symfony/* (Symfony packages already supports PHP 8.0)

Dev Dependencies

Other Tasks

Note

  • All new changes must be compatible with PHP 8.0.
  • Recommended PHP version is >= 7.3 but the changes are still compatible with 7.2.
  • We will keep the build step nightly and it is allowed to fail. Once the Travis target for PHP8 is added, we can update our step.

@ankitpokhrel ankitpokhrel mentioned this pull request Oct 31, 2020
Repository owner deleted a comment from codecov bot Oct 31, 2020
Repository owner deleted a comment from codecov bot Oct 31, 2020
Repository owner deleted a comment from codecov bot Oct 31, 2020
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #307 (daa2953) into master (dca27e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #307   +/-   ##
=========================================
  Coverage     99.68%   99.68%           
  Complexity      351      351           
=========================================
  Files            20       20           
  Lines           940      940           
=========================================
  Hits            937      937           
  Misses            3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca27e7...daa2953. Read the comment docs.

@ankitpokhrel ankitpokhrel merged commit dc387eb into master Nov 14, 2020
@ankitpokhrel ankitpokhrel deleted the php8 branch November 14, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant