Anti-pattern: (JS-0323) Fix

backend/package.json

@@ -107,4 +107,4 @@
   "engines": {
     "node": ">=15.0.0"
   }
-}
+}

backend/src/utils/helpers/validation.ts

@@ -1,11 +1,16 @@
 // eslint-disable-next-line import/prefer-default-export
-export function validateType(key: string, value: any, type: string) {
+export function validateType(key: string, value: unknown, type: string) {
   if (value === undefined || value === null) return `${key} is required.`;
-  if (type === 'number' && (Number.isNaN(value) || value <= 0)) {
-    return `${key} must be a valid positive number.`;
+
+  if (type === 'number') {
+    if (typeof value !== 'number' || isNaN(value) || value <= 0) {
+      return `${key} must be a valid positive number.`;
+    }
   }
-  if (type === 'boolean' && !['true', 'false', true, false].includes(value)) {
-    return `${key} must be true or false.`;
+  if (type === 'boolean') {
+    if (typeof value !== 'boolean') {
+      return `${key} must be true or false.`;
+    }
   }
   if (
     type === 'string[]' &&
@@ -14,5 +19,10 @@ export function validateType(key: string, value: any, type: string) {
   ) {
     return `${key} must be an array of non-empty strings.`;
   }
+  if (type === 'string') {
+    if (typeof value !== 'string' || value.trim() === '') {
+      return `${key} must be a non-empty string.`;
+    }
+  }
   return null;
 }

backend/test/unit/enrichment-service/helpers.test.ts

@@ -122,7 +122,7 @@ describe('enrichFromCache', () => {
       { id: '2', user_id: 'leadminer-1', email: '[email protected]' }
     ];
 
-    getCache.mockResolvedValue([{} as any]);
+    getCache.mockResolvedValue([{} as never]);
 
     const result = await enrichFromCache(getCache, enrichmentsDB, contacts);
 

backend/test/unit/validation.test.ts

@@ -0,0 +1,60 @@
+import { expect, test} from '@jest/globals';
+import { validateType } from '../../src/utils/helpers/validation';
+
+
+/* TESTING EMPTY VALUE */
+test('null/undefined value triggers error', () => {
+    expect(validateType('port', null, 'number')).toEqual('port is required.');
+});
+
+
+/* TESTING NUMBER VALIDATION */
+test('accepts a positive number properly', () => {
+    expect(validateType('port', 8808, 'number')).toBeNull();
+});
+
+test('rejects a negative number', () => {
+    expect(validateType('port', -1, 'number')).toEqual('port must be a valid positive number.');
+});
+
+test('rejects 0', () => {
+    expect(validateType('port', 0, 'number')).toEqual('port must be a valid positive number.');
+});
+
+test('rejects a value that is not a number', () => {
+    expect(validateType('port', 'error', 'number')).toEqual('port must be a valid positive number.');
+});
+
+
+/* TESTING BOOLEAN VALIDATION */
+test('accepts a true boolean properly', () => {
+    expect(validateType('secure', true, 'boolean')).toBeNull();
+});
+
+test('accepts a false boolean properly', () => {
+    expect(validateType('secure', false, 'boolean')).toBeNull();
+});
+
+test('rejects nonboolean values', () => {
+    expect(validateType('secure', 'error', 'boolean')).toEqual('secure must be true or false.');
+});
+
+
+/* TESTING STRING[] VALIDATION */
+test('accepts a string[] properly', () => {
+    expect(validateType('email', ['t','e','s','t','@','e','m','a','i','l','.','c','o','m'], 'string[]')).toBeNull();
+});
+
+test('rejects a nonstring array value', () => {
+    expect(validateType('email', [1, 2, 3], 'string[]')).toEqual('email must be an array of non-empty strings.');
+});
+
+
+/* TESTING STRING VALIDATION */
+test('accepts a string properly', () => {
+    expect(validateType('email', '[email protected]', 'string')).toBeNull();
+});
+
+test('rejects a nonstring value', () => {
+    expect(validateType('email', [1, 2, 3], 'string')).toEqual('email must be a non-empty string.');
+});

frontend/package.json

@@ -53,4 +53,4 @@
     "vue-tsc": "^2.2.0",
     "convert-csv-to-json": "^2.50.0"
   }
-}
+}

frontend/src/components/Mining/StepperPanels/MinePanel.vue

@@ -166,8 +166,8 @@ const totalEmails = computed<number>(() => {
   if (source.value === 'boxes' && boxes.value[0]) {
     return objectScan(['**.{total}'], {
       joined: true,
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      filterFn: ({ parent, property, value, context }: any) => {
+       
+      filterFn: ({ parent, property, value, context }: never) => {
         if (
           property === 'total' &&
           parent.key &&
@@ -215,7 +215,7 @@ onMounted(async () => {
 
   try {
     await $leadminerStore.fetchInbox();
-  } catch (error: any) {
+  } catch (error) {
     if (error?.statusCode === 502 || error?.statusCode === 503) {
       $stepper.prev();
       throw error;

package.json

@@ -22,4 +22,4 @@
   "devDependencies": {
     "supabase": "^2.2.1"
   }
-}
+}