-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Autofill snippets #444
base: main
Are you sure you want to change the base?
Conversation
Adding Autofill snippets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice some other code was added in AnimatedVisibilitySharedElementBlurSnippet.kt
and UserInteractions.kt
— are these needed? Otherwise, generally looks good!
compose/snippets/src/main/java/com/example/compose/snippets/text/AutofillSnippets.kt
Outdated
Show resolved
Hide resolved
compose/snippets/src/main/java/com/example/compose/snippets/text/AutofillSnippets.kt
Show resolved
Hide resolved
compose/snippets/src/main/java/com/example/compose/snippets/text/AutofillSnippets.kt
Show resolved
Hide resolved
CompositionLocalProvider(LocalAutofillHighlightColor provides customHighlightColor) { | ||
Column { | ||
BasicTextField( | ||
state = usernameState, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, should we just get rid of the usernameState
val and replace inline on line 130 state = remember ( TextFieldState() }
like the other samples do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i'll update
Adding Autofill snippets for documentation