Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Autofill snippets #444

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Adding Autofill snippets #444

wants to merge 11 commits into from

Conversation

MagicalMeghan
Copy link
Contributor

Adding Autofill snippets for documentation

MagicalMeghan and others added 2 commits January 28, 2025 16:21
@MagicalMeghan MagicalMeghan changed the base branch from main to latest January 28, 2025 21:41
@MagicalMeghan MagicalMeghan changed the base branch from latest to main January 28, 2025 21:50
Copy link

snippet-bot bot commented Jan 28, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

@mnuzen mnuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice some other code was added in AnimatedVisibilitySharedElementBlurSnippet.kt and UserInteractions.kt — are these needed? Otherwise, generally looks good!

CompositionLocalProvider(LocalAutofillHighlightColor provides customHighlightColor) {
Column {
BasicTextField(
state = usernameState,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, should we just get rid of the usernameState val and replace inline on line 130 state = remember ( TextFieldState() } like the other samples do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i'll update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants