Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All] Remove duplicate deps and use top-level libs.versions.toml as deps SoT. #1414

Merged
merged 2 commits into from
Jun 12, 2024
Merged

[All] Remove duplicate deps and use top-level libs.versions.toml as deps SoT. #1414

merged 2 commits into from
Jun 12, 2024

Conversation

arriolac
Copy link
Contributor

Changes:

  1. Removes duplicate dependencies from Glance and Wear in top-level libs.versions.toml
  2. Duplicates top-level libs.versions.toml to sample-specific libs.versions.toml by running ./scripts/duplicate_version_config.sh
  3. Update deps by running ./script/updateDeps.sh

@arriolac arriolac requested a review from a team as a code owner June 11, 2024 18:57
@arriolac arriolac changed the title Remove duplicate deps and use top-level libs.versions.toml as deps SoT. [All] Remove duplicate deps and use top-level libs.versions.toml as deps SoT. Jun 11, 2024
@arriolac
Copy link
Contributor Author

Looks like upgrading androidx-lifecycle to 2.8.1 causes tests to fail on Jetnews and Jetchat so I reverted the version back to 2.7.0 in 3c30d20.

@arriolac arriolac merged commit 050b6ae into main Jun 12, 2024
29 checks passed
@arriolac arriolac deleted the chris/fix_dependencies branch June 12, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentrengrove bentrengrove bentrengrove approved these changes

@JolandaVerhoef JolandaVerhoef Awaiting requested review from JolandaVerhoef JolandaVerhoef is a code owner automatically assigned from android/compose-devrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arriolac @bentrengrove