Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata provider. #131

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Add metadata provider. #131

merged 2 commits into from
Nov 12, 2023

Conversation

tachyonics
Copy link
Contributor

Issue #, if available: Add metadata provider that adds smoke-framework specific metadata to any logs emitted from the same structured concurrency tree rooted at the operation handler. This avoids the need to explicitly pass a logger instance around to emit this metadata for all related logs.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

}
}

/// A metadata provider exposing the attributes of the current invocation with the default key names..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two dots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

private enum InvocationContextKey: ServiceContextKey {
typealias Value = InvocationContext

static var nameOverride: String? = "smoke-framewrk-invocation-context"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

knovichikhin
knovichikhin previously approved these changes Nov 10, 2023
@tachyonics tachyonics merged commit d4ea018 into smoke-framework-2.x Nov 12, 2023
@tachyonics tachyonics deleted the metadata-provider branch November 12, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants