fix: correct message level for cppcheck fallback standard #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We provide no way to explicitly and separately (without changing
`CMAKE_<LANG>_STANDARD`) specify what standard cppcheck should use. Therefore,
when cppcheck fallbacking to use the default standard, the corresponding cmake
message should be `STATUS` instead of `${WARNING_MESSAGE}` which fails
the compilation when `WARNINGS_AS_ERRORS`.
aminya
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide no way to explicitly and separately (without changing
CMAKE_<LANG>_STANDARD) specify what standard cppcheck should use. Therefore, when cppcheck fallbacking to use the default standard, the corresponding cmake message should beSTATUSinstead of${WARNING_MESSAGE}which fails the compilation whenWARNINGS_AS_ERRORS.