Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unbundle] Changed to use plugin jekyll-3rd-party-libraries plugin #2978

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

george-gca
Copy link
Collaborator

I agree that it is a good idea to unbundle some of the plugins from al-folio, specially since they can be useful to more jekyll users overall. I have unbundled 2 plugins and created a gem for each one of them, so they can be easily integrated in any jekyll site. This is the first one of them.

@alshedivat alshedivat changed the title Changed to use plugin jekyll-3rd-party-libraries plugin [Unbundle] Changed to use plugin jekyll-3rd-party-libraries plugin Jan 27, 2025
@alshedivat
Copy link
Owner

@george-gca, thanks for contributing to unbundling, I'll take a closer look at these third party libraries.

I'll write up a more detailed plan in #2968 for how to best go about unbundling some of the functionality. for some of the common jekyll functionality (like cache busting or various 3rd party libraries) it makes sense to create general jekyll plugins (prefixing names of the ruby gems with jekyll-). for al-folio specific functionality (even things that depend on 3rd libraries), I decided to prefix plugin names with al- just to indicate that it's part of al-folio ecosystem. also, I created https://github.com/al-org-dev for all these unbundled al-folio-related repos.

@george-gca
Copy link
Collaborator Author

These plugins I created by moving code that can be more broadly used to their own plugins. Also created gems for them for easy installation.

Do you plan to move also post related features to plugins? I saw that you created #2984, but idk how hard it is to create a completely separated gem that can be also used for more sites from them. I mean, by ust installing a gem without you having to manually copy some js files to the repo that will use it.

Also I kept thinking about how could we avoid the merge that happens everytime a new functionality is added to the template. The best solution so far is to add these files to excludes in _config.yml, like recommended in #2933 (comment).

@alshedivat
Copy link
Owner

makes sense, thanks. and good question about moving post-related features to plugins, I'll look into this.

@alshedivat alshedivat merged commit d0b918b into alshedivat:v1.0-dev Feb 9, 2025
@george-gca george-gca deleted the 3rd_party_plugin branch February 9, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants