BREAKING CHANGE: Rename LmcCookieConsentManager to AlmaCareerCookieConsentManager #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cookie-consent-manager ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OndraM
force-pushed
the
bc/alma-career-code-rename
branch
from
449b202 to
7cbd5e2
Compare
OndraM
force-pushed
the
bc/settings-to-preferences
branch
from
46f2c3a to
5f5fd64
Compare
OndraM
force-pushed
the
bc/alma-career-code-rename
branch
from
7cbd5e2 to
59db146
Compare
literat
reviewed
Jan 3, 2025
| @@ -38,7 +38,7 @@ Load default CSS along with your styles in `<head>`: | |||
|
|
|||
| ```html | |||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Inter:wght@400;600;700&display=swap"> | |||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@lmc-eu/cookie-consent-manager@2/LmcCookieConsentManager.min.css"> | |||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@lmc-eu/cookie-consent-manager@2/AlmaCareerCookieConsentManager.min.css"> | |||
There was a problem hiding this comment.
suggestion (if-minor):
Suggested change
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@lmc-eu/cookie-consent-manager@2/AlmaCareerCookieConsentManager.min.css"> | |
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@almacareer/cookie-consent-manager@2/CookieConsentManager.min.css"> |
Two points:
- I think you forget to rename a package scope from
@lmc-eu->@almacareer - Do we still need to use a prefix for the file? Isn't
CookieConsentManagerjust enough? Because, I think, now the name of the file and the function names are way too long. And since this is a BC we can do better, IMHO.
There was a problem hiding this comment.
I think you forget to rename a package scope from @lmc-eu -> @almacareer
It will be done in a separate issue, see #391
There was a problem hiding this comment.
we can do better
I'm not sure whether it is actually better. The idea behind the prefix was/is to clearly distinguish from the underlying cookieconsent library.
However, you are right the name is now a bit long (I wouldn't say too long, but definitely longer than before 😄 ).
I will prepare second PR without the AlmaCareer prefix, to see how it looks, and we may choose that one.
…nsentManager (part of #392)
OndraM
force-pushed
the
bc/alma-career-code-rename
branch
from
59db146 to
4ed1ffb
Compare
|
Replaced by #400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #392.