Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotate.py:Rotate.border_mode docstring to tell the correct default. #2330

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

MalteEbner
Copy link
Contributor

@MalteEbner MalteEbner commented Feb 4, 2025

Description

In #2245, the border_mode was changed to cv2.BORDER_CONSTANT. However, the docstring was not updated. This PR fixes it by updating the docstring as well.

Tests

Not tested at all, as it only updates the docstring

Summary by Sourcery

Documentation:

  • Clarify the default border mode used in the Rotate transform.

Copy link
Contributor

sourcery-ai bot commented Feb 4, 2025

Reviewer's Guide by Sourcery

The pull request updates the docstring for the border_mode parameter in the Rotate class to reflect the correct default value, which is cv2.BORDER_CONSTANT.

Class diagram showing the Rotate class docstring update

classDiagram
    class Rotate {
        +rotate(image, angle, interpolation, border_mode, fill, fill_mask, rotate_method)
    }
    note for Rotate "border_mode default changed to cv2.BORDER_CONSTANT"
Loading

File-Level Changes

Change Details Files
Updated the docstring for the border_mode parameter in the Rotate class.
  • Corrected the default value of border_mode in the docstring to cv2.BORDER_CONSTANT.
albumentations/augmentations/geometric/rotate.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MalteEbner - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus
Copy link
Collaborator

ternaus commented Feb 4, 2025

Thanks. Trying my best to generate docstrings based on the code, but it the sitiation is far from perfect.

Thanks again.

@ternaus ternaus merged commit 752264b into albumentations-team:main Feb 4, 2025
14 checks passed
@MalteEbner MalteEbner deleted the patch-3 branch February 4, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants