Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GridDropout #2242

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Updated GridDropout #2242

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Enhancements:

  • Remove the deprecated MIN_UNIT_SIZE constant.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request refactors the GridDropout class by replacing deprecated parameters with their newer counterparts and removing redundant code.

Class diagram showing GridDropout changes

classDiagram
    class GridDropout {
        +InitSchema
        +__init__(ratio: float, random_offset: bool, unit_size_range: tuple, holes_number_xy: tuple, shift_xy: tuple)
    }

    class InitSchema {
        +ratio: float
        +random_offset: bool
        +unit_size_range: tuple
        +shift_xy: tuple
        +holes_number_xy: tuple
    }

    note for InitSchema "Removed deprecated fields:
    - unit_size_min
    - unit_size_max
    - holes_number_x
    - holes_number_y
    - shift_x
    - shift_y
    - fill_value
    - mask_fill_value"

    GridDropout -- InitSchema
Loading

File-Level Changes

Change Details Files
Deprecated parameters in GridDropout replaced with newer alternatives.
  • unit_size_min and unit_size_max replaced with unit_size_range.
  • holes_number_x and holes_number_y replaced with holes_number_xy.
  • shift_x and shift_y replaced with shift_xy.
  • fill_value replaced with fill.
  • mask_fill_value replaced with fill_mask.
albumentations/augmentations/dropout/grid_dropout.py
Removed deprecated parameter validation logic and associated warnings.
  • Removed the validate_normalization method which handled the deprecated parameters.
  • Removed the warning messages related to the deprecated parameters.
albumentations/augmentations/dropout/grid_dropout.py
Removed the MIN_UNIT_SIZE constant.
  • Removed the constant as it is no longer used after the refactoring.
albumentations/core/types.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (b1a79c2) to head (835db22).
Report is 348 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2242       +/-   ##
=========================================
+ Coverage      0   89.76%   +89.76%     
=========================================
  Files         0       50       +50     
  Lines         0     9069     +9069     
=========================================
+ Hits          0     8141     +8141     
- Misses        0      928      +928     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit f394b8c into main Jan 7, 2025
16 checks passed
@ternaus ternaus deleted the update_grid_dropout branch January 7, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant