Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ChannelDropout #2240

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Updated ChannelDropout #2240

merged 1 commit into from
Jan 7, 2025

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jan 7, 2025

Summary by Sourcery

Enhancements:

  • Replace the deprecated fill_value parameter with fill in ChannelDropout.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request updates the ChannelDropout transform by replacing the deprecated fill_value parameter with fill. It also removes the associated validator and warning.

Class diagram showing ChannelDropout parameter changes

classDiagram
    class ChannelDropout {
        +tuple[int, int] channel_drop_range
        +float fill
        +float p
        +__init__(channel_drop_range: tuple[int, int], fill: float, p: float)
    }
    note for ChannelDropout "Removed deprecated fill_value parameter
Replaced with fill parameter"
Loading

File-Level Changes

Change Details Files
Removed the deprecated fill_value parameter.
  • Removed the fill_value parameter from the __init__ method.
  • Removed the fill_value field from the InitSchema.
  • Removed the validator that checks and warns about the use of fill_value.
albumentations/augmentations/dropout/channel_dropout.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (b1a79c2) to head (4db34f1).
Report is 345 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2240       +/-   ##
=========================================
+ Coverage      0   89.75%   +89.75%     
=========================================
  Files         0       50       +50     
  Lines         0     9134     +9134     
=========================================
+ Hits          0     8198     +8198     
- Misses        0      936      +936     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 62c5499 into main Jan 7, 2025
16 checks passed
@ternaus ternaus deleted the update_channel_dropout branch January 7, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant