-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost version #2205
Boost version #2205
Conversation
Reviewer's Guide by SourceryThis PR makes two main changes: removes deprecation notices from height and width fields in InitSchema, and bumps the package version from 1.4.22 to 1.4.23. Updated class diagram for InitSchemaclassDiagram
class InitSchema {
+AfterValidator[] validators
+int|None width
+int|None height
+ScaleIntType|None size
+InterpolationType interpolation
+InterpolationType mask_interpolation
}
note for InitSchema "Removed deprecation notices from 'width' and 'height' fields."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Removing deprecation warnings is a breaking change that should be accompanied by a minor version bump (1.5.0) rather than a patch version bump.
- Consider keeping the deprecation warnings to help users migrate from 'height'/'width' to 'size'. Removing them without warning could cause confusion for users still using the old parameters.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2205 +/- ##
=========================================
+ Coverage 0 89.23% +89.23%
=========================================
Files 0 50 +50
Lines 0 8905 +8905
=========================================
+ Hits 0 7946 +7946
- Misses 0 959 +959 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Remove deprecation warnings for 'height' and 'width' fields in InitSchema and bump project version to 1.4.23.
Enhancements:
Build: