Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost version #2205

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Boost version #2205

merged 1 commit into from
Dec 17, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Dec 17, 2024

Summary by Sourcery

Remove deprecation warnings for 'height' and 'width' fields in InitSchema and bump project version to 1.4.23.

Enhancements:

  • Remove deprecation warnings for 'height' and 'width' fields in InitSchema.

Build:

  • Bump project version from 1.4.22 to 1.4.23 in pyproject.toml.

Copy link
Contributor

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This PR makes two main changes: removes deprecation notices from height and width fields in InitSchema, and bumps the package version from 1.4.22 to 1.4.23.

Updated class diagram for InitSchema

classDiagram
    class InitSchema {
        +AfterValidator[] validators
        +int|None width
        +int|None height
        +ScaleIntType|None size
        +InterpolationType interpolation
        +InterpolationType mask_interpolation
    }
    note for InitSchema "Removed deprecation notices from 'width' and 'height' fields."
Loading

File-Level Changes

Change Details Files
Removes deprecation notices from InitSchema fields
  • Removes deprecation notice from 'width' field
  • Removes deprecation notice from 'height' field
  • Fields are now declared without additional metadata
albumentations/augmentations/crops/transforms.py
Updates package version
  • Increments version from 1.4.22 to 1.4.23
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Removing deprecation warnings is a breaking change that should be accompanied by a minor version bump (1.5.0) rather than a patch version bump.
  • Consider keeping the deprecation warnings to help users migrate from 'height'/'width' to 'size'. Removing them without warning could cause confusion for users still using the old parameters.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (b1a79c2) to head (40e9323).
Report is 316 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2205       +/-   ##
=========================================
+ Coverage      0   89.23%   +89.23%     
=========================================
  Files         0       50       +50     
  Lines         0     8905     +8905     
=========================================
+ Hits          0     7946     +7946     
- Misses        0      959      +959     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 51b9089 into main Dec 17, 2024
16 checks passed
@ternaus ternaus deleted the boost_version branch December 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant