-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can pass images as np.array (num_images, height, width, num_channels) #2185
Conversation
Reviewer's Guide by SourceryThis PR adds support for passing multiple images as a numpy array with shape (num_images, height, width, num_channels) instead of only supporting lists of images. The implementation modifies the core transform interface to handle both array and list formats while maintaining backward compatibility. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
=========================================
+ Coverage 0 89.76% +89.76%
=========================================
Files 0 47 +47
Lines 0 8448 +8448
=========================================
+ Hits 0 7583 +7583
- Misses 0 865 +865 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Allow images to be passed as numpy arrays with shape (num_images, height, width, num_channels) to transformation functions, ensuring output format consistency. Update tests to cover both list and numpy array input formats.
New Features:
Enhancements:
Tests: