Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix params #2175

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Fix params #2175

merged 3 commits into from
Dec 5, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Dec 5, 2024

Summary by Sourcery

Enhancements:

  • Refactor test cases to improve readability by reformatting long lines and restructuring parameterized tests.

Copy link
Contributor

sourcery-ai bot commented Dec 5, 2024

Reviewer's Guide by Sourcery

This pull request primarily focuses on code formatting improvements and the removal of the RotateAndProject transform. The changes include extensive reformatting using black code formatter to improve code readability, removal of the RotateAndProject transform and its related functionality, and some minor code cleanup.

Class diagram for the removal of RotateAndProject transform

classDiagram
    class RotateAndProject {
        - x_angle_range: tuple[float, float]
        - y_angle_range: tuple[float, float]
        - z_angle_range: tuple[float, float]
        - focal_range: tuple[float, float]
        - border_mode: int
        - fill: ColorType
        - fill_mask: ColorType
        - interpolation: InterpolationType
        - mask_interpolation: InterpolationType
        - p: float
        - always_apply: bool | None
        + get_params_dependent_on_data(params: dict[str, Any], data: dict[str, Any])
        + get_transform_init_args_names() -> tuple[str, ...]
        + apply_to_bboxes(bboxes: np.ndarray, matrix_bbox: np.ndarray, max_height: int, max_width: int, **params: Any) -> np.ndarray
    }
    note for RotateAndProject "This class has been removed in the PR"
Loading

File-Level Changes

Change Details Files
Removed RotateAndProject transform and its related functionality
  • Removed RotateAndProject class and its implementation
  • Removed get_rotation_matrix_3d and get_projection_matrix functions
  • Updated all list to remove RotateAndProject
  • Removed RotateAndProject from README.md documentation
  • Removed RotateAndProject from test definitions
albumentations/augmentations/geometric/rotate.py
albumentations/augmentations/geometric/functional.py
README.md
tests/aug_definitions.py
Applied black code formatter across multiple files
  • Reformatted function definitions with long parameter lists
  • Fixed line length issues by breaking long lines
  • Improved alignment and indentation of function arguments
  • Reformatted long array and dictionary literals
  • Fixed import statement formatting
tests/test_transforms.py
albumentations/augmentations/geometric/functional.py
albumentations/augmentations/geometric/transforms.py
albumentations/augmentations/blur/transforms.py
Updated MotionBlur transform default parameters
  • Changed default direction_range from (-0.5, 0.5) to (-1.0, 1.0)
  • Reordered parameters in constructor to match standard pattern
albumentations/augmentations/blur/transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 95.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (b1a79c2) to head (4a6ba3e).
Report is 299 commits behind head on main.

Files with missing lines Patch % Lines
albumentations/augmentations/geometric/rotate.py 85.00% 3 Missing ⚠️
...bumentations/augmentations/geometric/transforms.py 96.20% 3 Missing ⚠️
albumentations/augmentations/blur/transforms.py 90.00% 2 Missing ⚠️
...bumentations/augmentations/geometric/functional.py 98.76% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2175       +/-   ##
=========================================
+ Coverage      0   89.77%   +89.77%     
=========================================
  Files         0       47       +47     
  Lines         0     8434     +8434     
=========================================
+ Hits          0     7572     +7572     
- Misses        0      862      +862     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit a9000e2 into main Dec 5, 2024
16 checks passed
@ternaus ternaus deleted the fix_params branch December 5, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant