-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix params #2175
Fix params #2175
Conversation
Reviewer's Guide by SourceryThis pull request primarily focuses on code formatting improvements and the removal of the RotateAndProject transform. The changes include extensive reformatting using black code formatter to improve code readability, removal of the RotateAndProject transform and its related functionality, and some minor code cleanup. Class diagram for the removal of RotateAndProject transformclassDiagram
class RotateAndProject {
- x_angle_range: tuple[float, float]
- y_angle_range: tuple[float, float]
- z_angle_range: tuple[float, float]
- focal_range: tuple[float, float]
- border_mode: int
- fill: ColorType
- fill_mask: ColorType
- interpolation: InterpolationType
- mask_interpolation: InterpolationType
- p: float
- always_apply: bool | None
+ get_params_dependent_on_data(params: dict[str, Any], data: dict[str, Any])
+ get_transform_init_args_names() -> tuple[str, ...]
+ apply_to_bboxes(bboxes: np.ndarray, matrix_bbox: np.ndarray, max_height: int, max_width: int, **params: Any) -> np.ndarray
}
note for RotateAndProject "This class has been removed in the PR"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
=========================================
+ Coverage 0 89.77% +89.77%
=========================================
Files 0 47 +47
Lines 0 8434 +8434
=========================================
+ Hits 0 7572 +7572
- Misses 0 862 +862 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Enhancements: