feat: add bioweapon mode as fan mode #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bioweapon mode can be turned on/off independently from other preset modes like Camp mode or Dog mode. By using fan mode, you can have both Bioweapon mode and Camp mode turned on at the same time. Requires commits to teslajsonpy to be merged to funcion.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Please handle the teslajsonpy bump and we can merge this in. |
|
I updated the files with teslajsonpy 3.11.0. Not too sure about poetry.lock file but I updated the version and the hash manually |
|
You need to run poetry update. |
This reverts commit 6caf6bb.
|
Thanks. Please take a look at the failing test. You can ignore the precommit error since that looks like something unrelated to climate. |
|
I think I got it? Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bioweapon mode as fan mode. Bioweapon mode can be turned on independently of other preset modes such as dog mode or camp mode, so it is better to include it as fan mode instead of one of the preset modes.
Requires zabuldon/teslajsonpy/pull/468