Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow implicit dependencies #13

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nikolai-laevskii
Copy link

Description:

  1. Added ESLint rule that disallows implicit dependencies (dependencies that are not specified in package.json). The motivation for that is that this is very unsafe because implicit dependencies rely on installed global packages and dependencies installed for other specified dependencies. If needed dependency is not installed locally or some of packages stops using it as dependency, it will fail to resolve. Moreover, it takes whichever version is already installed and doesn't take even major version into account
  2. Changed existing implicit dependencies to explicit

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@nikolai-laevskii nikolai-laevskii self-assigned this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants