Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Artem,
I wanted to add
GetAppend
to the library, so we can enhance performance of our sync layer, because it required a lot of reading from DB for large documents.GetAppend
appends the value data to the buffer.In my implementation I decided to copy the code of the function, because If I would reuse the same code with some modifications this would make the original Get function slower which is bad for performance critical library like yours (the reason is that
append
works slower thancopy
).These are the benchmarks on latest MacOs on M3 MacBook Air and my friend's linux laptop for
GetAppend
: