Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AcePopup): fix aria-posinset issue on google chrome #5719

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

xyos
Copy link
Contributor

@xyos xyos commented Jan 16, 2025

Description of changes:

This change addresses an issue in Chromium where an incorrect sequence of aria-posinset values can occur when navigating from bottom to top using the keyboard. This wrong order of posinset sequence causes screen readers to announce an incorrect total count of items, even when aria-setsize is explicitly defined. The fix ensures only the selected item will have aria-posinset so we can maintain correct accessibility behavior across screen readers.

before change:

Screen.Recording.2025-01-16.at.1.01.57.PM.mov

after change:

Screen.Recording.2025-01-16.at.1.03.07.PM.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (85f01ca) to head (741f601).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5719      +/-   ##
==========================================
+ Coverage   87.02%   87.03%   +0.01%     
==========================================
  Files         598      598              
  Lines       43593    43628      +35     
  Branches     7163     7163              
==========================================
+ Hits        37936    37971      +35     
  Misses       5657     5657              
Flag Coverage Δ
unittests 87.03% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xyos xyos merged commit 09a0c5a into ajaxorg:master Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants