fix(AcePopup): fix aria-posinset issue on google chrome #5719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change addresses an issue in Chromium where an incorrect sequence of
aria-posinset
values can occur when navigating from bottom to top using the keyboard. This wrong order ofposinset
sequence causes screen readers to announce an incorrect total count of items, even whenaria-setsize
is explicitly defined. The fix ensures only the selected item will havearia-posinset
so we can maintain correct accessibility behavior across screen readers.before change:
Screen.Recording.2025-01-16.at.1.01.57.PM.mov
after change:
Screen.Recording.2025-01-16.at.1.03.07.PM.mov
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: