fix(source-google-sheets): add sheet id encoding #52671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtractor that matches schema properties with values
…in components resolver in order to get an indexed object of properties where index is the order. - Add partition router to retriver in components resolver so we can slice.
- Remove old SourceClass to temp file to be deleted and - Remove unused transformations - Make extractor ha transform data from component mapping
…anges to discard empty cells in first row
…and unavailable stream
… code in response
… github.com:airbytehq/airbyte into aldogonzalez8/source-google-sheets/migrate-low-code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
…ub.com:airbytehq/airbyte into lazebnyi/fix-sheed-id-encode-for-google-sheets
lazebnyi
requested review from
pnilan,
aaronsteers and
aldogonzalez8
and removed request for
natikgadzhi,
aldogonzalez8,
pnilan and
aaronsteers
|
Regression tests looks good - Job 1 Only |
aldogonzalez8
approved these changes
Jan 31, 2025
maxi297
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the connector, query parameters are passed directly in the path and they are not encoded. Therefore, when the sheet ID (sheet name) contains special characters, the URL may not be resolved correctly.
Example:
Old version:
Sheet1 one col&special name%?->range=Sheet1%20one%20col&special%20name%?!1:1New version:
Sheet1 one col&special name%?->ranges=Sheet1%20one%20col%26special%20name%25%3F!1:1How
Add
urlencodeto path resolvingUser Impact
No
Can this PR be safely reverted and rolled back?