-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add F
flag to remove unused imports
#52649
Open
artem1205
wants to merge
3
commits into
master
Choose a base branch
from
artem1205/precommit-fix-unused-imports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/format-fix
|
Running formatters to see what the diff would be :) |
I personally think this is a good idea, so if CI is green-adjacent, we should prob merge this. |
…-fix-unused-imports # Conflicts: # airbyte-ci/connectors/connector_ops/connector_ops/required_reviewer_checks.py # airbyte-integrations/connectors/source-google-sheets/unit_tests/integration/custom_http_mocker.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
connectors/destination/astra
connectors/destination/duckdb
connectors/destination/motherduck
connectors/destination/pinecone
connectors/destination/timeplus
connectors/destination/vectara
connectors/source/airtable
connectors/source/amazon-ads
connectors/source/amazon-seller-partner
connectors/source/amazon-sqs
connectors/source/amplitude
connectors/source/aws-cloudtrail
connectors/source/braze
connectors/source/chargebee
connectors/source/convex
connectors/source/facebook-marketing
connectors/source/file
connectors/source/gcs
connectors/source/github
connectors/source/gong
connectors/source/google-ads
connectors/source/google-analytics-data-api
connectors/source/google-drive
connectors/source/google-sheets
connectors/source/greenhouse
connectors/source/hubspot
connectors/source/instagram
connectors/source/instatus
connectors/source/jira
connectors/source/klaviyo
connectors/source/linkedin-ads
connectors/source/linnworks
connectors/source/microsoft-sharepoint
connectors/source/mixpanel
connectors/source/my-hours
connectors/source/mysql
connectors/source/okta
connectors/source/paypal-transaction
connectors/source/pinterest
connectors/source/railz
connectors/source/recharge
connectors/source/rss
connectors/source/s3
connectors/source/salesforce
connectors/source/shopify
connectors/source/slack
connectors/source/stripe
connectors/source/surveymonkey
connectors/source/tiktok-marketing
connectors/source/typeform
connectors/source/xero
connectors/source/zendesk-chat
connectors/source/zendesk-support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add
F
flag to remove unused importsHow
add
F
flag to remove unused importsReview guide
User Impact
Can this PR be safely reverted and rolled back?