Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S3-Data-Lake] Make the Namespace/Database a required field #52639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frifriSF59
Copy link
Contributor

What

Make the Database or Namespace mandatory in all catalogs
Noting that all the currently used secrets have been updated

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

@frifriSF59 frifriSF59 self-assigned this Jan 29, 2025
@frifriSF59 frifriSF59 requested a review from a team as a code owner January 29, 2025 22:32
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 29, 2025 10:43pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3-data-lake labels Jan 29, 2025
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably need to regen the expected specs

@@ -26,7 +26,7 @@ data:
alias: airbyte-connector-testing-secret-store
connectorType: destination
definitionId: 716ca874-520b-4902-9f80-9fad66754b89
dockerImageTag: 0.2.23
dockerImageTag: 0.2.24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this with the json stringify stuff, but let's do a bigger version bump for breaking change :P

Suggested change
dockerImageTag: 0.2.24
dockerImageTag: 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3-data-lake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants