Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-gorgias contribution from engageandy #52637

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

engageandy
Copy link

@engageandy engageandy commented Jan 29, 2025

What

This PR updates source Gorgias (source-gorgias).

The contributor provided the following description of the change:

All streams updated to use the "Retry-after" header when rate limited.

Changed the tickets stream's cursor field to "updated_datetime". Tickets are mutable.

In views_items, added parent "view_id" to additional views and included in view_id + id composite key to resolve duplicate key errors.

Website: https://gorgias.com/
API docs: https://developers.gorgias.com/reference/introduction
Auth docs: https://developers.gorgias.com/reference/authentication
API Keys: https://testerstoreusedbytester.gorgias.com/app/settings/api

Reviewer checklist

  • Resolve any merge conflicts and validate file diffs (make sure the PR only includes changes intended by the contributor)
  • After reviewing the changes, run the bump-version Airbyte-CI command locally to update the version of the connector according to the versioning guidelines. Add breakingChanges to metadata if necessary.
  • Ensure connector docs are up to date with any changes
  • Run /format-fix to resolve any formatting errors
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Jan 29, 2025

@engageandy is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

I'm cleaning this up (a few Builder bugs creeping in), and from there we will bump the version and get this merged.

@natikgadzhi
Copy link
Contributor

@marcosmarxm have time to bump the version on this?

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Jan 30, 2025

/bump-version type="minor" changelog="Add retries for rate limited streams"

Bump Version job started... Check job output.

✅ Changes applied successfully. (44cda5d)

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 9:43pm

@natikgadzhi natikgadzhi enabled auto-merge (squash) January 30, 2025 21:38
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CI is happy, we should merge this. Toggled automerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/gorgias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants