Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source: Zendesk Support - Update Error Message For organization_access_enabled on Check #52625

Merged

Conversation

agarctfi
Copy link
Contributor

…s_enabled on Check

What

Solves future cases of: https://github.com/airbytehq/oncall/issues/7281#issue-2793543980

Users can get this error message when setting up a source for Zendesk Support
Screenshot 2025-01-29 at 10 10 23 AM

The message is too generic, and users who have admin access can still get this error.

How

It seems we only check for organization_access_enabled in active_features for this. If so, we can be more specific with the error code. The article provided links to Zendesk article on how to enable this feature.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 11:13am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support labels Jan 29, 2025
@agarctfi
Copy link
Contributor Author

agarctfi commented Jan 29, 2025

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@natikgadzhi
Copy link
Contributor

@agarctfi I'm rebasing this over master with a potential fix for the CI problem

@lazebnyi
Copy link
Collaborator

lazebnyi commented Feb 4, 2025

@agarctfi I fixed the CAT issue, so you can proceed with this PR.

@agarctfi agarctfi merged commit 6a0b214 into master Feb 4, 2025
28 checks passed
@agarctfi agarctfi deleted the agactfi/source-zendesk-support/imporove-error-message branch February 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants