-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source: Zendesk Support - Update Error Message For organization_access_enabled on Check #52625
Merged
agarctfi
merged 16 commits into
master
from
agactfi/source-zendesk-support/imporove-error-message
Feb 4, 2025
Merged
Source: Zendesk Support - Update Error Message For organization_access_enabled on Check #52625
agarctfi
merged 16 commits into
master
from
agactfi/source-zendesk-support/imporove-error-message
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_enabled on Check
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/zendesk-support
labels
Jan 29, 2025
/format-fix
|
lazebnyi
approved these changes
Jan 29, 2025
@agarctfi I'm rebasing this over master with a potential fix for the CI problem |
@agarctfi I fixed the CAT issue, so you can proceed with this PR. |
agarctfi
deleted the
agactfi/source-zendesk-support/imporove-error-message
branch
February 4, 2025 15:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/zendesk-support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s_enabled on Check
What
Solves future cases of: https://github.com/airbytehq/oncall/issues/7281#issue-2793543980
Users can get this error message when setting up a source for Zendesk Support
The message is too generic, and users who have admin access can still get this error.
How
It seems we only check for
organization_access_enabled
inactive_features
for this. If so, we can be more specific with the error code. The article provided links to Zendesk article on how to enable this feature.Review guide
User Impact
Can this PR be safely reverted and rolled back?