Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[run CI] Source Facebook Marketing: Add status filters #35276

Closed

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Feb 14, 2024

What

This PR is created specifically to execute CI for: #32449, incorporating minor fixes and introducing a migration strategy for stream state to prevent breaking changes. The original parameter has been retained in the new state structure to ensure backward compatibility.

AdCreative statuses were deleted because this endpoint doesn't support status filters.

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:24pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 14, 2024
@tolik0 tolik0 marked this pull request as ready for review February 14, 2024 13:51
@tolik0 tolik0 self-assigned this Feb 14, 2024
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@tolik0 tolik0 force-pushed the tolik0/source-facebook-marketing/add-status-filters branch from 960b98d to d1e8a06 Compare February 15, 2024 11:19
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 15, 2024 11:20
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add changes to customer's PR and test it this separate PR - #34900

@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 18, 2024 14:34
@tolik0 tolik0 force-pushed the tolik0/source-facebook-marketing/add-status-filters branch from ad7bcf4 to 13ea3fc Compare February 20, 2024 15:09
@tolik0 tolik0 changed the title ✨ Source Facebook Marketing: Add status filters [run CI] Source Facebook Marketing: Add status filters Feb 20, 2024
@tolik0
Copy link
Contributor Author

tolik0 commented Feb 20, 2024

The original PR is merged.

@tolik0 tolik0 closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants