Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination postgres: improve sentry error grouping #35266

Closed
wants to merge 4 commits into from

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Feb 14, 2024

as noted in https://github.com/airbytehq/alpha-beta-issues/issues/2857 - postgres is now dv2, so we should make it use the error deinterpolator

Removed the logic about only emitting a custom trace if we modify the message. Postgres errors are frequently non-deinterpolatable (e.g. ERROR: canceling statement due to statement timeout), but we still want to group on their error message.

(and, uh, that logic doesn't seem justifiable in retrospect. Presumably even if the error message has no connection-specific words, we don't want to group on the default fingerprint anyway)

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 0:49am

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao marked this pull request as ready for review February 14, 2024 00:49
@edgao edgao requested a review from a team as a code owner February 14, 2024 00:49
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 14, 2024
@edgao
Copy link
Contributor Author

edgao commented Mar 1, 2024

done in #35760

@edgao edgao closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/postgres connectors/destination/postgres-strict-encrypt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants