Destination postgres: improve sentry error grouping #35266
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as noted in https://github.com/airbytehq/alpha-beta-issues/issues/2857 - postgres is now dv2, so we should make it use the error deinterpolator
Removed the logic about only emitting a custom trace if we modify the message. Postgres errors are frequently non-deinterpolatable (e.g.
ERROR: canceling statement due to statement timeout
), but we still want to group on their error message.(and, uh, that logic doesn't seem justifiable in retrospect. Presumably even if the error message has no connection-specific words, we don't want to group on the default fingerprint anyway)