Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use lists instead of streams in TestDatabase #35122

Closed
wants to merge 3 commits into from
Closed

use lists instead of streams in TestDatabase #35122

wants to merge 3 commits into from

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 9:16am

@stephane-airbyte stephane-airbyte mentioned this pull request Feb 10, 2024
Closed
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Feb 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Feb 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from b79379d to 6febfeb Compare February 10, 2024 03:18
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from a08dbab to c680d2a Compare February 10, 2024 03:18
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 10, 2024
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch 4 times, most recently from 979417b to d731848 Compare February 10, 2024 09:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch 2 times, most recently from c854486 to 3f28bce Compare February 10, 2024 15:53
This was referenced Feb 10, 2024
Closed
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from d731848 to 84bf501 Compare February 13, 2024 19:20
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 13, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 3f28bce to 479c231 Compare February 13, 2024 19:31
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 84bf501 to 4317dea Compare February 13, 2024 19:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 479c231 to 5c84710 Compare February 13, 2024 19:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 4317dea to 3f48107 Compare February 16, 2024 00:44
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 16, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch from 3f48107 to 2f31ce7 Compare February 16, 2024 00:46
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 5c84710 to 962841b Compare February 16, 2024 00:48
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-fix_msssql_tests_take_3 branch 2 times, most recently from 6393401 to 6e5f022 Compare February 16, 2024 01:02
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch 3 times, most recently from 388cae0 to 6dce30c Compare February 22, 2024 23:49
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Feb 22, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-fix_junit_test_error_logging branch from 805a180 to 3c188a8 Compare February 23, 2024 22:54
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 6dce30c to 99c7083 Compare February 23, 2024 22:54
This was referenced Feb 24, 2024
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from 99c7083 to f7f920b Compare February 24, 2024 02:51
This was referenced Feb 24, 2024
Merged
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-fix_junit_test_error_logging branch from 3c188a8 to 553ea49 Compare February 24, 2024 09:16
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-09-use_lists_instead_of_streams_in_TestDatabase branch from f7f920b to e2a990e Compare February 24, 2024 09:16
This was referenced Feb 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@stephane-airbyte stephane-airbyte force-pushed the stephane/02-21-fix_junit_test_error_logging branch from 553ea49 to ca186d7 Compare February 26, 2024 23:05
@stephane-airbyte stephane-airbyte marked this pull request as ready for review February 26, 2024 23:10
@stephane-airbyte stephane-airbyte marked this pull request as draft February 26, 2024 23:11
Base automatically changed from stephane/02-21-fix_junit_test_error_logging to master February 26, 2024 23:36
This was referenced Feb 27, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CDK Connector Development Kit connectors/source/mssql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephane-airbyte @octavia-squidington-iii