Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Freshsales : Migrate Python CDK to Low-code CDK #31685

Merged
merged 10 commits into from
Nov 13, 2023

Conversation

ariesgun
Copy link
Contributor

@ariesgun ariesgun commented Oct 20, 2023

What

Migrate Source Freshdesk from Python CDK to Low-code CDK.
Issue #28993

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. manifest.yaml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 8:04pm

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! πŸŽ‰

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ariesgun ariesgun marked this pull request as ready for review October 20, 2023 22:16
@marcosmarxm marcosmarxm added hackathon-2023-10 low-code-migration This connector has been migrated to the low-code CDK labels Oct 23, 2023
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ariesgun

@marcosmarxm marcosmarxm merged commit 855d6a4 into airbytehq:master Nov 13, 2023
30 of 41 checks passed
@nataliekwong
Copy link
Contributor

Hey @ariesgun - would you know why this error now shows up when syncing Contacts?

Duplicate keys found: {'filter', 'page', 'sort', 'per_page', 'sort_type'}

@fbarlas89
Copy link

After this update, the connector is failing with the following error as mentioned by @nataliekwong above as well.

Duplicate keys found: {'filter', 'page', 'sort', 'per_page', 'sort_type'}

@marcosmarxm
Copy link
Member

Can you open a Github issue for the problem?

@nataliekwong
Copy link
Contributor

Created here: #33102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/freshsales hackathon-2023-10 low-code-migration This connector has been migrated to the low-code CDK
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants