Vector DBs: Set subtype correctly #31647

flash1293 · 2023-10-20T10:31:47Z

What

#31521 added the vectorstore connector subtype - this PR rolls this out to all connectors fitting the type.

vercel · 2023-10-20T10:31:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 20, 2023 1:14pm

github-actions · 2023-10-20T10:32:10Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-10-20T10:35:18Z

destination-weaviate test report (commit `1388554ec9`) - ✅

⏲️ Total pipeline duration: 01mn51s

Step	Result
Build destination-weaviate docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for destination-weaviate	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-weaviate test

airbyte-oss-build-runner · 2023-10-20T10:36:05Z

destination-pinecone test report (commit `1388554ec9`) - ✅

⏲️ Total pipeline duration: 02mn38s

Step	Result
Build destination-pinecone docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for destination-pinecone	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

airbyte-oss-build-runner · 2023-10-20T10:36:13Z

destination-milvus test report (commit `1388554ec9`) - ✅

⏲️ Total pipeline duration: 02mn46s

Step	Result
Build destination-milvus docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for destination-milvus	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

airbyte-oss-build-runner · 2023-10-20T10:36:15Z

destination-qdrant test report (commit `1388554ec9`) - ❌

⏲️ Total pipeline duration: 02mn49s

Step	Result
Build destination-qdrant docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Check our base image is used	❌
Code format checks	✅
Validate metadata for destination-qdrant	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-qdrant test

airbyte-oss-build-runner · 2023-10-20T10:36:29Z

destination-chroma test report (commit `1388554ec9`) - ❌

⏲️ Total pipeline duration: 03mn03s

Step	Result
Build destination-chroma docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Check our base image is used	❌
Code format checks	✅
Validate metadata for destination-chroma	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-chroma test

airbyte-oss-build-runner · 2023-10-20T13:15:51Z

destination-qdrant test report (commit `6fee2d3436`) - ✅

⏲️ Total pipeline duration: 01mn30s

Step	Result
Build destination-qdrant docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Code format checks	✅
Validate metadata for destination-qdrant	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-qdrant test

airbyte-oss-build-runner · 2023-10-20T13:15:52Z

destination-chroma test report (commit `6fee2d3436`) - ✅

⏲️ Total pipeline duration: 01mn32s

Step	Result
Build destination-chroma docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Code format checks	✅
Validate metadata for destination-chroma	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-chroma test

airbyte-oss-build-runner · 2023-10-20T13:16:26Z

destination-weaviate test report (commit `6fee2d3436`) - ✅

⏲️ Total pipeline duration: 02mn07s

Step	Result
Build destination-weaviate docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for destination-weaviate	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-weaviate test

airbyte-oss-build-runner · 2023-10-20T13:16:35Z

destination-pinecone test report (commit `6fee2d3436`) - ✅

⏲️ Total pipeline duration: 02mn16s

Step	Result
Build destination-pinecone docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for destination-pinecone	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

airbyte-oss-build-runner · 2023-10-20T13:17:36Z

destination-milvus test report (commit `6fee2d3436`) - ✅

⏲️ Total pipeline duration: 03mn18s

Step	Result
Build destination-milvus docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for destination-milvus	✅
Connector version semver check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

aaronsteers

👍

set subtype correctly

1388554

flash1293 requested a review from a team as a code owner October 20, 2023 10:31

octavia-squidington-iii added area/connectors Connector related issues connectors/destination/weaviate connectors/destination/milvus connectors/destination/pinecone connectors/destination/qdrant connectors/destination/chroma labels Oct 20, 2023

Merge branch 'master' into flash1293/vectorstore-metadata

6fee2d3

vercel bot deployed to Preview October 20, 2023 13:14 View deployment

aaronsteers approved these changes Oct 25, 2023

View reviewed changes

flash1293 merged commit 34f9d26 into master Oct 25, 2023
16 checks passed

flash1293 deleted the flash1293/vectorstore-metadata branch October 25, 2023 10:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vector DBs: Set subtype correctly #31647

Vector DBs: Set subtype correctly #31647

flash1293 commented Oct 20, 2023

vercel bot commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited by flash1293

Loading

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

airbyte-oss-build-runner commented Oct 20, 2023

aaronsteers left a comment

Vector DBs: Set subtype correctly #31647

Vector DBs: Set subtype correctly #31647

Conversation

flash1293 commented Oct 20, 2023

What

vercel bot commented Oct 20, 2023 • edited Loading

github-actions bot commented Oct 20, 2023 • edited by flash1293 Loading

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 20, 2023

destination-weaviate test report (commit 1388554ec9) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-pinecone test report (commit 1388554ec9) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-milvus test report (commit 1388554ec9) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-qdrant test report (commit 1388554ec9) - ❌

airbyte-oss-build-runner commented Oct 20, 2023

destination-chroma test report (commit 1388554ec9) - ❌

airbyte-oss-build-runner commented Oct 20, 2023

destination-qdrant test report (commit 6fee2d3436) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-chroma test report (commit 6fee2d3436) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-weaviate test report (commit 6fee2d3436) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-pinecone test report (commit 6fee2d3436) - ✅

airbyte-oss-build-runner commented Oct 20, 2023

destination-milvus test report (commit 6fee2d3436) - ✅

aaronsteers left a comment

Choose a reason for hiding this comment

vercel bot commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited by flash1293

Loading

destination-weaviate test report (commit `1388554ec9`) - ✅

destination-pinecone test report (commit `1388554ec9`) - ✅

destination-milvus test report (commit `1388554ec9`) - ✅

destination-qdrant test report (commit `1388554ec9`) - ❌

destination-chroma test report (commit `1388554ec9`) - ❌

destination-qdrant test report (commit `6fee2d3436`) - ✅

destination-chroma test report (commit `6fee2d3436`) - ✅

destination-weaviate test report (commit `6fee2d3436`) - ✅

destination-pinecone test report (commit `6fee2d3436`) - ✅

destination-milvus test report (commit `6fee2d3436`) - ✅