Buffer overflow in SmallVec::insert_many
Critical severity
GitHub Reviewed
Published
May 24, 2022
to the GitHub Advisory Database
•
Updated Sep 18, 2023
Package
Affected versions
>= 0.6.3, < 0.6.14
>= 1.0.0, < 1.6.1
Patched versions
0.6.14
1.6.1
Description
Published by the National Vulnerability Database
Jan 26, 2021
Published to the GitHub Advisory Database
May 24, 2022
Reviewed
Jun 17, 2022
Last updated
Sep 18, 2023
A bug in the SmallVec::insert_many method caused it to allocate a buffer that was smaller than needed. It then wrote past the end of the buffer, causing a buffer overflow and memory corruption on the heap. This bug was only triggered if the iterator passed to insert_many yielded more items than the lower bound returned from its size_hint method.
The flaw was corrected in smallvec 0.6.14 and 1.6.1, by ensuring that additional space is always reserved for each item inserted. The fix also simplified the implementation of insert_many to use less unsafe code, so it is easier to verify its correctness.
References