ensure speaker github handle are unique #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienpoly
force-pushed
the
github-uniqueness
branch
2 times, most recently
from
ea91b50 to
c1e2199
Compare
adrienpoly
force-pushed
the
github-uniqueness
branch
from
c1e2199 to
bfa3644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while the name is not require to be uniq the github handle should be
before being able to merge this PR we must clean the production DB as we have duplicates for those handles
CoralineAda
JEG2
andrew
chancancode
egiurleo
eileencodes
flavorjones
gus4no
hasumikin
headius
hogelog
hsbt
j-manu
jonatas
khasinski
kou
matz
mrzasa
nusco
okuramasafumi
olivierlacan
rafaelfranca
rheinwein
tagomoris
tamacodechi
wndxlori
wycats
even with a simple seed from an empty database we have duplicates
some are coming from the list of canonical being added to the speakers.yml. We should separate those and clear the github handle when we set a canonical speaker