show less avatars in mobile to prevent overflow #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Nov 20, 2024
Comment on lines
+237
to
+238
| <% speakers_with_avatars.each_with_index do |speaker, index| %> | ||
| <div class="<%= class_names("avatar bg-white border-2", "hidden lg:block" => index > 8) %>"> |
There was a problem hiding this comment.
I think this technically breaks the +[number] count on mobile, since you don't add the missing four to the count.
There was a problem hiding this comment.
true let's make it 8 for everyone then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this section would overflow on mobile thus the entire page overflows as seen in #404