Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group talks on speakers#show page #299

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

marcoroth
Copy link
Collaborator

@marcoroth marcoroth commented Oct 25, 2024

This pull request introduces the concept of grouped talks (similar to what was described in #236).

If we find grouped talks on a speaker profile we show a tab bar with "Grouped" and "Ungrouped" options, where the ungrouped option is the previous show page.

Grouped Ungrouped
CleanShot 2024-10-27 at 18 33 19 CleanShot 2024-10-27 at 18 39 46

if we don't find any grouped talks on a speakers profile we show just the list of talks as it was before:

No Grouped Talks
CleanShot 2024-10-25 at 18 52 42

@marcoroth marcoroth force-pushed the groupable-talks branch 2 times, most recently from 6addfc3 to 3c787ba Compare October 25, 2024 16:58
@adrienpoly
Copy link
Owner

I like this idea to highlight grouped talks but I feel like the tab display is a bit overkilled and maybe not that obvious for the visitor.

I wonder if we could keep the talks into a single grid, reorder the talks so that grouped talks are adjacent and span them in the grid with some kind of border to show that they are similar talks

Or another alternative is to start introducing a sorting menu.

  • most recent (default)
  • least recent
  • grouped

@marcoroth
Copy link
Collaborator Author

marcoroth commented Oct 27, 2024

I'm not sure I follow. Are you just saying the UI for selecting the "view" is overkill or the functionally in general?

I improved the grouping slighty comparer to what you see in the screenshots. It's grouping the non-grouped talks into their release year now too, which helps with navigating the talks.

@adrienpoly
Copy link
Owner

I'm not sure I fellow. Are you just saying the UI for selecting the "view" is overkill or the functionally in general?

Yes having a tab for that might seems overkill to me. To me it is a kind of sorting so we should be able to add a date sorting order at some point to the UI. With this tab it become more complex I think

I improved the grouping slighty comparer to what you see in the screenshots. It's grouping the non-grouped talks into their release year now too, which helps with navigating the talks.

I will try it live

@marcoroth
Copy link
Collaborator Author

Updated the screenshots for Aaron's profile. You can click on them to view them in the full resolution.

@adrienpoly adrienpoly force-pushed the main branch 2 times, most recently from ca98c66 to aa6f659 Compare November 10, 2024 15:03
@marcoroth marcoroth marked this pull request as draft November 26, 2024 15:39
@adrienpoly adrienpoly force-pushed the main branch 2 times, most recently from 97e3bb3 to 953a362 Compare January 27, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants