-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group talks on speakers#show
page
#299
base: main
Are you sure you want to change the base?
Conversation
6addfc3
to
3c787ba
Compare
3c787ba
to
93aae0f
Compare
I like this idea to highlight grouped talks but I feel like the tab display is a bit overkilled and maybe not that obvious for the visitor. I wonder if we could keep the talks into a single grid, reorder the talks so that grouped talks are adjacent and span them in the grid with some kind of border to show that they are similar talks Or another alternative is to start introducing a sorting menu.
|
I'm not sure I follow. Are you just saying the UI for selecting the "view" is overkill or the functionally in general? I improved the grouping slighty comparer to what you see in the screenshots. It's grouping the non-grouped talks into their release year now too, which helps with navigating the talks. |
Yes having a tab for that might seems overkill to me. To me it is a kind of sorting so we should be able to add a date sorting order at some point to the UI. With this tab it become more complex I think
I will try it live |
Updated the screenshots for Aaron's profile. You can click on them to view them in the full resolution. |
ca98c66
to
aa6f659
Compare
97e3bb3
to
953a362
Compare
This pull request introduces the concept of grouped talks (similar to what was described in #236).
If we find grouped talks on a speaker profile we show a tab bar with "Grouped" and "Ungrouped" options, where the ungrouped option is the previous show page.
if we don't find any grouped talks on a speakers profile we show just the list of talks as it was before: