Integrate cache service v2 #1857
Draft
+9,236
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robherley
reviewed
Oct 24, 2024
There was a problem hiding this comment.
any reason why we have these dependencies now in the top level package.json?
| @@ -38,6 +38,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@actions/core": "^1.10.0", | |||
| "@actions/artifact": "^2.1.7", | |||
There was a problem hiding this comment.
i'm hesitant to have cache depend on artifact if it's only for obtaining the tokens from the environment. is there a better package we can move that logic to (core?)
There was a problem hiding this comment.
Ideally yes. For now, I'm just going to duplicate the logic so that we can decrease the complexity of the rollout
Comment on lines
+9
to
+12
| // TODO: Use the feature flag to determine the cache service version | ||
| export function getCacheServiceVersion(): string { | ||
| return process.env['ACTIONS_CACHE_SERVICE_VERSION'] || 'v1' | ||
| } |
There was a problem hiding this comment.
when this is fixed, we should include some logic to check for results env too. we don't want to end up removing the feature flag after ship and attempting to hit v2 in GHES
|
H |
Liabaemt
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the cache package to integrate with the new cache service backend (cache service v2). Major changes to the API layer are involved with this change but the interfaces are backward compatible. The transition to the new service will undergo gradual rollout and will be seamless to end users.
More context
Deprecation notice for v1 and v2 of actions/cache