Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tencent Kona JDK #672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnshajiang
Copy link
Contributor

@johnshajiang johnshajiang commented Aug 14, 2024

Description:
This PR adds Tencent Kona JDK into setup-java.
It supports the major versions 8, 11, 17 and 21.
The supported platforms are Linux x86_64/aarch64, macOS x86_64/aarch64 and Windows x86_64.

Currently, only the latest stable releases are supported, and only jdk (no jre) binaries are available.
A configuration maintains these releases.

Related issue:
#671

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@johnshajiang
Copy link
Contributor Author

I just refreshed the commit.
It resolved the file conflicts and supported Tencent Kona JDK 21.

@johnshajiang
Copy link
Contributor Author

I just updated the commit again, and the file conflicts are resolved.

@johnshajiang johnshajiang force-pushed the support-kona-jdk branch 3 times, most recently from 41ce0ca to 109744b Compare February 13, 2025 08:31
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
@johnshajiang
Copy link
Contributor Author

johnshajiang commented Feb 13, 2025

I already executed npm run build for re-generating the index.js files, and committed them.

> [email protected] build
> ncc build -o dist/setup src/setup-java.ts && ncc build -o dist/cleanup src/cleanup-java.ts

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using [email protected] (local user-provided)
5204kB  dist/setup/index.js
5204kB  [2160ms] - ncc 0.38.1
ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using [email protected] (local user-provided)
3777kB  dist/cleanup/index.js
3777kB  [1804ms] - ncc 0.38.1

But Check dist check task always failed.

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant