add support for artifact proxy repositories #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denizhoxha
force-pushed
the
feature/support-proxy-repositoy
branch
from
b23412e
to
cec33d9
Compare
|
@marko-zivic-93 Any feedback on this PR? |
|
Hi, @kuhlman-labs 👋 We will investigate it and get back with our feedback. |
IvanZosimov
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change supports teams that have configured their self-managed runners without internet access. They are proxying all the necessary public repositories via platforms like JFrog, Nexus etc. This can support especially teams that are using GHES.
I am proposing to add three inputs to action.yml
1- base url of the platform that is proxying the remote repositories
2- the download link that needs to be rewritten so the java binaries are download from this platforms
3- a context which might be necessary to build a proper download link. This might be necessary because the URL of the metadata.json file is different from the URL of the download link and the assumption is that teams have only one platform to proxy the remote repositores.
Related issue:
Check list: