Fetch repo-level runner groups from API in v2 flow #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (path.Length == 1) | ||
| var isOrgRunner = path.Length == 1; | ||
| var isRepoOrEnterpriseRunner = path.Length == 2; | ||
| var isRepoRunner = !string.Equals(path[0], "enterprises", StringComparison.OrdinalIgnoreCase); |
There was a problem hiding this comment.
Would it be better to say
var isRepoRunner = isRepoOrEnterpriseRunner && !string.Equals(path[0], "enterprises", StringComparison.OrdinalIgnoreCase);Otherwise, isRepoRunner would be true even in the org case (may not matter how you're using it, but it'd be good to not have a wrong value if we use it in the future)
| if (path.Length == 1) | ||
| var isOrgRunner = path.Length == 1; | ||
| var isRepoOrEnterpriseRunner = path.Length == 2; | ||
| var isRepoRunner = !string.Equals(path[0], "enterprises", StringComparison.OrdinalIgnoreCase); |
There was a problem hiding this comment.
same logic question here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch repo-level runner groups from API in v2 flow.