Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ACTIONS_RUNNER_INJECT_RUNNER_SERVICE_ACCOUNT environment variable #186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcopalmisano
Copy link

Hi team! :)

As mentioned here, we in eDo hit the same behavior of @Hchanni.

Analysing the problem, we found out that when a runner starts a -workflow pod with hooks, it doesn't automatically propagate its service account.

In our case with Workload Identities, this is needed, and even if we can workaround the problem creating a ConfigMap and placing in the runner container as a file to make an override (using ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATE), this is still a feature that could be helpful for lot of people.

This won't be the default behavior because I understand it's a breaking change, but I added a new environment variable ACTIONS_RUNNER_INJECT_RUNNER_SERVICE_ACCOUNT to allow the automatic "parent injection"

@marcopalmisano marcopalmisano requested review from a team as code owners November 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant