-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug trace for library #159
base: main
Are you sure you want to change the base?
Conversation
Hey @timmjd, Thank you so much for the great work you put in to make this change. I will set aside some time this week or next week to go through these changes, but from the glimpse of it, it seems like a very useful addition to the hook! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix types in tests. They can be fixed with simple as Type
. Other than that, this looks good to me
As a self hosted runner administrator i want so know why my runners are crashing. If this is related to k8s, a stack trace often does help to pin down the origin of the issue.
Therefore, this change does improve the debug capability of the k8s hook implementation by providing a stack trace via the debug output if an exception happend.
Before the change
After the change
Change summary
The primary change is to enable a correct
sourceMap
output for the code, so the stack trace will show up the.ts
origin with the correct line number of the trace and not some location within the minified / bakedindex.js
.packages/hooklib
and thepackages/k8s
andpackages/docker
was changed from a JS based include into a TypeScript composite build. To make this happen, thebaseUrl
&rootUrl
required adaptation.tsc
followed byncc
was replaced with a direct call ofncc
due to otherwise the line number reference got lost.k8s/package.json
that appear now due to the linkage is happening now on a typed based linkage. I guess there was also a bug within themainContainerContextPorts[port.containerPort]
assignment.ncc
andtypescript
library update was required due to the used version caused a bug.