Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In consideration of a future v5, update minimum git version. #1653

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

In consideration of a future v5, update minimum git version. #1653

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8926c30
In consideration of a future v5, update minimum git version.
jww3 Mar 12, 2024
db715dc
Update git-command-manager.ts
jww3 Mar 12, 2024
06abf55
ran `npm run build`
jww3 Mar 12, 2024
64dbc81
updated other version-specific logic
jww3 Mar 12, 2024
425626d
Bump `MinimumGitVersion` to 2.28 due to #1386
jww3 Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/git-command-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import {GitVersion} from './git-version'

// Auth header not supported before 2.9
// Wire protocol v2 not supported before 2.18
export const MinimumGitVersion = new GitVersion('2.18')
// sparse-checkout not supported before 2.25
export const MinimumGitVersion = new GitVersion('2.25')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://git-scm.com/docs/git-sparse-checkout/2.25.0
and note that https://git-scm.com/docs/git-sparse-checkout/2.24.0 results in a redirect to https://git-scm.com/docs/git-sparse-checkout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: minimum git version should be 2.28 (see #1386)


export interface IGitCommandManager {
branchDelete(remote: boolean, branch: string): Promise<void>
Expand Down
Loading