Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics cardinality for ghalistener #3671

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

metrics cardinality for ghalistener #3671

wants to merge 5 commits into from

Conversation

christophermichaeljohnston
Copy link

Remove runner_id and runner_name from metrics as these are unique for each ephemeral runner cause a new metric for every action.

fixes #3670

@christophermichaeljohnston
Copy link
Author

job_workflow_ref also causes horrible high cardinality so I removed it

@christophermichaeljohnston
Copy link
Author

christophermichaeljohnston commented Oct 25, 2024 •
edited
Loading

The result of this are metrics that function as actual counters:

gha_completed_jobs_total{enterprise="",event_name="push",job_name="test",job_result="succeeded",organization="...",repository="..."} 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

@rentziass rentziass Awaiting requested review from rentziass rentziass is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ghalistener high cardinality metrics
1 participant
@christophermichaeljohnston