[IMP] client to return mocked server version #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds legit. Can you update the documentation and add a small test for that? |
|
Sure, will do. |
nilshamerlinck
force-pushed
the
client_mock
branch
from
cccf6d4 to
f8a60bf
Compare
nilshamerlinck
force-pushed
the
client_mock
branch
from
f8a60bf to
c00bac7
Compare
|
Done @sbidoul |
|
@nilshamerlinck I had definitely lost track of this. If you still need this, can you rebase as I've done some CI maintenance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odoo checks for wkhtmltopdf's version on start.
In a CI context, we don't necessarily want to run the kwkhtmtopdf container.
Provided with
KWKHTMLTOPDF_SERVER_URL=MOCKenvironment variable, the client will return "wkhtmltopdf 0.12.5 (mock)" and Odoo will start properly.