Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visitor): visit decorators before visiting type #160

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

jamieshorten
Copy link
Contributor

Fixes an issue with visitors where the decorators of scalar fields and relationships where not visited.

Changes

Visit the decorators of scalar fields and relationships before visiting their types

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@coveralls
Copy link

coveralls commented Dec 17, 2024

Coverage Status

coverage: 98.772% (+0.001%) from 98.771%
when pulling 6eb818d on jamieshorten:main
into 7f83d5f on accordproject:main.

Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for expediency. We need some tests though

lib/common/basevisitor.js Outdated Show resolved Hide resolved
Co-authored-by: Matt Roberts <[email protected]>
Signed-off-by: Jamie Shorten <[email protected]>
@mttrbrts mttrbrts enabled auto-merge (squash) December 17, 2024 16:42
@mttrbrts mttrbrts merged commit 7a84504 into accordproject:main Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants