Corrected offset for args in printf #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Athishpranav2003
force-pushed
the
fix-printf
branch
from
76b27a2 to
a0cc9f7
Compare
|
There is a slight change observed in the behavior of printf arguments. Consecutive Integer arguments are clubbed together and aligned to multiple of 8 bytes together(ideally should have done have been aligned individually). Latest push addresses the issue
|
Signed-off-by: Athishpranav2003 <[email protected]>
Athishpranav2003
force-pushed
the
fix-printf
branch
from
a0cc9f7 to
86b5d02
Compare
tgrogers
reviewed
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset for the arguments earlier for printf was 1 byte even tho the arguments are aligned to 8 bytes. Now this PR fixes this issue