Fixed some of GCC warnings #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(which are just typedefs over QStyleOptionViewItem class)
- Flags box - Size box - Point box - Rectangle box
TODO: - Be sure is need to save full dump of given settings, or it's fine to absent of some - Complete other types - Make a proper manager class for everything that can be re-used
Those flags are making binary be non-portable and crashy on different CPUs
- missing "else" that makes it be inavailable
- It has more functionality include picking a color from screen. On some systems it may lack some important things.
Split biggies into separated parts, they are VERY inconvenient to manage
- Remove unneeded margin - Make the field width fit with a text - Draw a border around color indicator box
If you made a group with a name that equals to "..", all content of this branch will be dropped into a parent branch in the settings dump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.