Move e2e out client #389
Move e2e out client #389
Conversation
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "ft": "npm run format && npm t", | |||
| "format": "cd client/ && npm run format && cd ../server/ && npm run format && cd ../ && prettier --write \"build/*.mjs\" \"docu/**/*.mjs\" ", | |||
| "format": "cd client/ && npm run format && cd ../server/ && npm run format && cd ../poinz-e2e/ && npm run format && cd ../ && prettier --write \"build/*.mjs\" \"docu/**/*.mjs\" ", | |||
There was a problem hiding this comment.
note:
I think we could use npm workspace to simplify this. Then you could run npm run format --workspaces
And what does prettier --write "build/.mjs" "docu/**/.mjs" do?
There was a problem hiding this comment.
prettier --write is to format files in glob pattern. The paths are js files to generate diagrams & build artifacts.
For introducing workspace, I've tested it and found the behaviours of installing dependencies would change. The dependencies of all packages would be centralised at root level. This change would also change the ways of deployment. I'd suggest to defer this decision until deployment revamp.
There was a problem hiding this comment.
seems like CI/CD still fails, can you check pls, then I will merge it :)
| @@ -20,6 +20,7 @@ import socketIo from 'socket.io-client'; | |||
| * @return {string} | |||
| */ | |||
| export const tid = (...tid) => tid.map((t) => `[data-testid="${t}"]`).join(' '); | |||
| export const customNanoid = customAlphabet('0123456789abcdefghijklmnopqrstuvwxyz-_', 21); | |||
There was a problem hiding this comment.
question:
I assume you just copied this from import uuid from '../../app/services/uuid';?
There was a problem hiding this comment.
yes. this is to isolate the dependency between current client util function and e2e package
Context: Move e2e cypress app out of client