Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <TextField multiline/> word breaking #309

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

Saladinek
Copy link
Contributor

@Saladinek Saladinek commented Oct 22, 2020

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

This is a partial fix to issue #305

@Saladinek Saladinek changed the title Fix TextField word breaking Fix TextField word breaking for issue 305 Oct 22, 2020
@Saladinek
Copy link
Contributor Author

Current TextField:
badWordBreak

After Fix:
correctWordBreak

@dimabory dimabory changed the title Fix TextField word breaking for issue 305 Fix TextField word breaking Oct 22, 2020
@dimabory dimabory changed the title Fix TextField word breaking Fix <TextField multiline/> word breaking Oct 22, 2020
@dimabory
Copy link
Collaborator

it looks nice. could you cover this case by the visual test + snapshot?

@dimabory dimabory merged commit 7ebe425 into ZEISS:develop Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants