Removing refocus on every onChange Event in Autocomplete
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimabory
reviewed
Jan 21, 2020
dimabory
suggested changes
Jan 28, 2020
dimabory
reviewed
Jan 28, 2020
dimabory
reviewed
Jan 31, 2020
dimabory
reviewed
Feb 4, 2020
CHANGELOG.md
Outdated
| - Fix opening `UploaderProgressDetails` behind modal in IE (#225) | ||
| - Remove refocus of component(Autocomplete) on every value change, remove corresponding test |
There was a problem hiding this comment.
I just updated origin. It's no more 1.0.1. Can you update the version and changelog?
There was a problem hiding this comment.
Also seems like it is kind of Breaking Change, but I wouldn't say it completely changes the functionality, it rather fixes the issue, so probably we can bump up the minor version.
There was a problem hiding this comment.
Also seems like it is kind of Breaking Change, ...
..., so probably we can bump up the minor version
@Saladinek Could you update a minor instead of a patch?
dimabory
approved these changes
Feb 5, 2020
dimabory
changed the title
onChange Event in Autocomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Removing refocus on every onChange Event as it breaks the very principle of onFocus functionality.
Also removing corresponding test case. This PR corresponds to issue #228
For now adding "Breaking Change" option, as it changes the current 'intended' functionality.