TestRunner code cleanup #8571
Open
TestRunner code cleanup #8571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Tondak <[email protected]>
|
Can one of the admins verify this patch? |
added 2 commits
October 24, 2024 23:36
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
aktondak
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
AShivangi
requested changes
Oct 29, 2024
| @@ -20,7 +21,6 @@ namespace xq = xrt_core::query; | |||
| // System - Include Files | |||
| #include <fstream> | |||
| #include <iostream> | |||
| #include <regex> | |||
There was a problem hiding this comment.
thanks for cleaning up includes as well!
| /* | ||
| * search for xclbin for a legacy platform | ||
| */ | ||
| std::string |
There was a problem hiding this comment.
This is a good time to remove dead code. Let's remove this function and any mention of it
There was a problem hiding this comment.
Cleaned up after confirmation
| @@ -3,6 +3,7 @@ | |||
| // ------ I N C L U D E F I L E S ------------------------------------------- | |||
| // Local - Include Files | |||
| #include "TestBist.h" | |||
| #include "TestValidateUtilities.h" | |||
There was a problem hiding this comment.
Can you ask Max if this is still a valid test? If not, let's remove it
There was a problem hiding this comment.
Max pointed to a confirmation from @chvamshi-xilinx
Waiting for reply to decide on this clean-up
Signed-off-by: Akshay Tondak <[email protected]>
AShivangi
reviewed
Nov 11, 2024
| @@ -3,6 +3,7 @@ | |||
| // ------ I N C L U D E F I L E S ------------------------------------------- | |||
| // Local - Include Files | |||
| #include "TestPsIops.h" | |||
| #include "TestValidateUtilities.h" | |||
There was a problem hiding this comment.
Please remove this testcase as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This code cleans up the TestRunner class by moving all the APIs which do not belong there to the TestValidateUtilities namespace.
This code clean-up is an effort towards building the runner recipe based xrt-smi validate test. This will facilitate the following:
Note: ps+aie, ps+validate tests may be still required for embedded+platform
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/VITIS-13774
Discovered to internal analysis of Validate Tests.
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved by moving the mentioned APIs out of the class and altering the usage points of these APIs to have appropriate scopes.
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested by running all xrt-smi validate tests on krackenmachine
Documentation impact (if any)
None