Propagate XRT Include Directory in CMake target #8027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When foreign CMake projects link against XRT::xrt_coreutil
The target's property INTERFACE_INCLUDE_DIRECTORIES is empty.
Today our customers resolve this by doing
This really shouldn't be necessary, because this library is unusable without header files.
We can allow the include directory to propagate.
This will fix issues where another project creates an interface library that links XRT.
For instance here is a hack I'm having to do:
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Discovered while trying to create an interface library that links XRT.
How problem was solved, alternative solutions (if any) and why they were rejected
See code change
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
I've done no testing, this is my proposed fix to ensure that the include directory property can propagate to the end user.
Documentation impact (if any)
None