Fix Build Fixed build path

Wtyd · May 9, 2024 · 6602412 · 6602412
1 parent ab83048
commit 6602412
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -51,6 +51,7 @@ jobs:
         php --version
         php githooks app:pre-build php
         php githooks app:build
+        git status --short
   
     - name: Upload build artifact
       uses: actions/upload-artifact@v4

diff --git a/app/Commands/Zero/BuildCommand.php b/app/Commands/Zero/BuildCommand.php
@@ -103,7 +103,7 @@ private function build(string $name): BuildCommand
         // $this->tarBuild($name);
         // TODO la compilación bien pero falta mencionar el tar
         $this->output->writeln(
-            sprintf('    Compiled successfully: <fg=green>%s</>', $this->build->getBuildPath() . DIRECTORY_SEPARATOR . $name)
+            sprintf('    Compiled successfully: <fg=green>%s</>', $this->build->getBuildPath() . $name)
         );
 
         return $this;

diff --git a/src/Build/Build.php b/src/Build/Build.php
@@ -25,7 +25,7 @@ public function __construct()
      */
     private function setPhpVersion(): void
     {
-        $this->phpVersion = implode('.', array_slice(explode('.', phpversion()), 0, 2));
+        $this->phpVersion = phpversion();
     }
 
     /**
@@ -38,7 +38,7 @@ private function setPhpVersion(): void
     private function setBuildPath(): void
     {
         $path = 'builds' . DIRECTORY_SEPARATOR;
-
+        // TODO: Refactor this to use a switch statement like getTarName()
         if (version_compare($this->phpVersion, '7.1', '<')) {
             throw new Exception('GitHooks only supports php 7.1 or greater.', 1);
         }
@@ -67,7 +67,8 @@ public function getPhpVersion(): string
     public function getTarName(): string
     {
         $tarName = '';
-        switch ($this->phpVersion) {
+
+        switch (implode('.', array_slice(explode('.', $this->phpVersion), 0, 2))) {
             case '7.1':
             case '7.2':
                 $tarName = 'githooks-7.1.tar';